Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to slice images and subjects #1170

Merged
merged 4 commits into from
May 14, 2024
Merged

Conversation

fepegar
Copy link
Owner

@fepegar fepegar commented May 5, 2024

Resolves #1011.

Description

See @marius-sm's feature request.

I would appreciate it if someone could please take a look!
@marius-sm @abenicho @wahabk @HyunKyungHan

Checklist

  • I have read the CONTRIBUTING docs and have a developer setup (especially important are pre-commitand pytest)
  • Non-breaking change (would not break existing functionality)
  • Breaking change (would cause existing functionality to change)
  • Tests added or modified to cover the changes
  • Integration tests passed locally by running pytest
  • In-line docstrings updated
  • Documentation updated, tested running make html inside the docs/ folder
  • This pull request is ready to be reviewed

@fepegar fepegar marked this pull request as draft May 13, 2024 22:09
@fepegar fepegar self-assigned this May 13, 2024
@fepegar fepegar marked this pull request as ready for review May 14, 2024 23:04
@fepegar fepegar merged commit e13e756 into main May 14, 2024
16 checks passed
@fepegar fepegar deleted the 1011-support-image-slicing branch May 14, 2024 23:05
@fepegar
Copy link
Owner Author

fepegar commented May 14, 2024

@allcontributors please add @marius-sm for ideas

Copy link
Contributor

@fepegar

I've put up a pull request to add @marius-sm! 🎉

@marius-sm
Copy link

Hi @fepegar, very nice! Sorry for not contributing more myself. I am not coding anymore at the moment.

@fepegar
Copy link
Owner Author

fepegar commented May 15, 2024

No worries!

@fepegar
Copy link
Owner Author

fepegar commented May 15, 2024

I hope you're ok with being added to the contributor list.

@marius-sm
Copy link

marius-sm commented May 15, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pythonic slicing support to torchio.Image
3 participants