Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated cover image and styles for it. #53

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

jackreichert
Copy link
Contributor

thank you again for this wonderful project!

@jackreichert
Copy link
Contributor Author

I hope it's okay, I completely missed some styling with my original merge request. While I was fixing that I found a cover image that I think works even better. I'd really appreciate it if you could accept this one too.

@femmebot
Copy link
Owner

Ah, so sorry I haven't been able to get to this sooner!

I checked the new background image and it visually competes with the typography. There's insufficient contrast between the background image and foreground/type. The green color also tends to vibrate against red. Perhaps you could revert to the former image or find another way to feature the typography more prominently and legibly?

Also, mind adding the entry after https://femmebot.github.io/google-type/index.html#femmebot-07 just to keep the sequence in the chronological order they were submitted.

Thanks and happy holidays!

@jackreichert
Copy link
Contributor Author

Thanks so much for your feedback. I took a second look and was able to simply resolve it with a couple well-placed lines of css. I also moved my submission to the location you requested.

I hope you have had a wonderful holiday season and thanks again for including me!

Jack

@femmebot femmebot self-requested a review October 18, 2018 20:03
Repository owner locked as resolved and limited conversation to collaborators Jul 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants