Skip to content
This repository has been archived by the owner on Sep 11, 2021. It is now read-only.

wait for the installation of windows-build-tools #225

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aminya
Copy link

@aminya aminya commented Aug 25, 2020

This PR tries to fix the problem of endless waits.

Changes

  1. Add --wait to vs build tools
    Based on the documentation, with this option:

the process will wait until the install is completed before returning an exit code. This is useful when automating installations where one needs to wait for the install to finish to handle the return code from that install.

Fixes #172
Fixes #216
Fixes #208
Fixes #147
Fixes #215
Fixes #200
Fixes #105
Fixes #145
Fixes #97

@aminya aminya marked this pull request as draft August 25, 2020 11:04
@jacobq
Copy link
Collaborator

jacobq commented Aug 25, 2020

Have you tried this? (Does it work?)

@aminya
Copy link
Author

aminya commented Aug 25, 2020

It doesn't fully solve the issue yet. That's why it is still a draft.

@jacobq jacobq mentioned this pull request Aug 25, 2020
@quinton-ashley
Copy link

Please fix this

@aminya
Copy link
Author

aminya commented Oct 20, 2020

To fix this we need to find a better way to understand if the installation is done. Currently, the script waits for the installation log, which does not seem like the best way to determine the end of the installation.

@jacobq
Copy link
Collaborator

jacobq commented Jan 23, 2021

Just checking in as this still appears to be in WIP. Any plans to continue development? Are there tasks for which you'd like to get help from others?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.