-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add basic multiarch build #663
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Michael Wei <michael@wei.email>
Thanks @no2chem. Could you attempt a build and let us know how fast it runs? Last time I tried it it was painfully slow but I didn't spend much time on it either. |
Hm, if you think it's going to be painfully slow I can take a few minutes to modify the dockerfile to cross-compile instead. I know rustc is definitely slow in qemu. |
What I recall trying was using |
Yeah more or less. I added multiarch cross-compile to the dockerfile so hopefully it works, just running it locally, will let you know if it works after I come back from lunch Also, node 19.x I guess is deprecated, it causes a 60 second wait displaying a warning, might be worth updating it to 20 if it doesn't break anything for you. |
Signed-off-by: Michael Wei <michael@wei.email>
Okay, I added a cross compiling dockerfile which seems to work. I don't know how long it'll add to your build pipeline because I can't run it, but it appears to complete in a reasonable amount of time for me locally. |
Before we used a script that is now deprecated. They also added a 60s deprecation warning to that script as reported by @no2chem in #663. This updates to the recommended method described here: https://github.com/nodesource/distributions#ubuntu-versions Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
Before we used a script that is now deprecated. They also added a 60s deprecation warning to that script as reported by @no2chem in #663. This updates to the recommended method described here: https://github.com/nodesource/distributions#ubuntu-versions Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
Before we used a script that is now deprecated. They also added a 60s deprecation warning to that script as reported by @no2chem in #663. This updates to the recommended method described here: https://github.com/nodesource/distributions#ubuntu-versions Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
This PR adds a basic multiarch build, modifying the
containers.yml
pipeline to build both linux/amd64 and linux/arm64 images using buildx.QEMU is used to perform the multiarch build on arm64, since Github runners don't support CI yet. This could be potentially slow. If it is, we could modify the Dockerfile to use $TARGETARCH vars and direct the compilers to cross-compile instead.