[SQL] support more features for window aggregates #1742

mihaibudiu · 2024-05-11T01:58:05Z

Is this a user-visible change (yes/no): almost

Fixes #459

This PR removes some limitations on the partitioned_window_aggregates supported:

We still have limitations, but these will be addressed in separate PRs.

The work involves adding a bunch of Rust code and traits:

traits to distinguish signed and unsigned types
traits to prevent partitioned_rolling_aggregate being instantiated with signed types
traits to help wrapping SQL types into unsigned types preserving order

@ryzhyk can you please review just the Rust part?

crates/dbsp/src/algebra/mod.rs

crates/dbsp/src/operator/time_series/rolling_aggregate.rs

...r/SQL-compiler/src/main/java/org/dbsp/sqlCompiler/ir/expression/literal/DBSPI128Literal.java

sql-to-dbsp-compiler/lib/sqllib/src/aggregates.rs

sql-to-dbsp-compiler/lib/sqllib/src/interval.rs

sql-to-dbsp-compiler/lib/sqllib/src/lib.rs

Signed-off-by: Mihai Budiu <mbudiu@feldera.com>

mihaibudiu force-pushed the partitioned_window branch 3 times, most recently from dccd7df to 136efa7 Compare May 11, 2024 02:10

ryzhyk approved these changes May 13, 2024

View reviewed changes

mihaibudiu force-pushed the partitioned_window branch from 136efa7 to 1af67b6 Compare May 14, 2024 00:39

[SQL] Support more features for window aggregates

11ba50b

Signed-off-by: Mihai Budiu <mbudiu@feldera.com>

mihaibudiu force-pushed the partitioned_window branch from 1af67b6 to 11ba50b Compare May 14, 2024 00:42

mihaibudiu merged commit 561dd6d into main May 14, 2024
4 of 5 checks passed

mihaibudiu deleted the partitioned_window branch May 14, 2024 00:52

Provide feedback