Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebConsole: update dependencies, update test snapshots #1732

Merged
merged 2 commits into from
May 14, 2024
Merged

Conversation

Karakatiza666
Copy link
Collaborator

Is this a user-visible change (yes/no):no

@Karakatiza666 Karakatiza666 added Web Console Related to the browser based UI javascript Pull requests that update Javascript code labels May 9, 2024
@Karakatiza666 Karakatiza666 requested a review from gz May 9, 2024 00:03
@gz
Copy link
Collaborator

gz commented May 9, 2024

last time we a upgrade of many dependencies at once it caused a bunch of breakage in the UI. Did you test all the functionality in depth? If not lets do that before we merge, I can also have a look when you're done

@Karakatiza666
Copy link
Collaborator Author

Went through the UI, fixed minor regressions, as well as the bug that causes crash in secops demo when trying to deserialize SQL TIMESTAMP value with microseconds

@Karakatiza666 Karakatiza666 changed the title WebConsole: update dependencies WebConsole: update dependencies, enable playwright May 10, 2024
@Karakatiza666 Karakatiza666 force-pushed the ui-deps branch 2 times, most recently from e96f870 to 69e9aba Compare May 10, 2024 14:58
@Karakatiza666 Karakatiza666 changed the title WebConsole: update dependencies, enable playwright WebConsole: update dependencies, update test snapshots May 10, 2024
@gz
Copy link
Collaborator

gz commented May 13, 2024

getting a bunch of warnings during yarn install we should probably declare these peer dependencies?

warning "@playwright/experimental-ct-react > @vitejs/plugin-react@4.2.1" has unmet peer dependency "vite@^4.2.0 || ^5.0.0".
warning " > @typescript-eslint/eslint-plugin@7.8.0" has incorrect peer dependency "@typescript-eslint/parser@^7.0.0".
warning " > @typescript-eslint/eslint-plugin@7.8.0" has incorrect peer dependency "eslint@^8.56.0".
warning "@typescript-eslint/eslint-plugin > @typescript-eslint/type-utils@7.8.0" has incorrect peer dependency "eslint@^8.56.0".
warning "@typescript-eslint/eslint-plugin > @typescript-eslint/utils@7.8.0" has incorrect peer dependency "eslint@^8.56.0".
warning " > @typescript-eslint/parser@6.21.0" has incorrect peer dependency "eslint@^7.0.0 || ^8.0.0".
warning " > eslint-config-next@14.2.3" has incorrect peer dependency "eslint@^7.23.0 || ^8.0.0".
warning "eslint-config-next > @typescript-eslint/parser@7.2.0" has incorrect peer dependency "eslint@^8.56.0".
warning " > eslint-plugin-import@2.29.1" has incorrect peer dependency "eslint@^2 || ^3 || ^4 || ^5 || ^6 || ^7.2.0 || ^8".
warning "eslint-config-next > eslint-plugin-jsx-a11y@6.8.0" has incorrect peer dependency "eslint@^3 || ^4 || ^5 || ^6 || ^7 || ^8".
warning " > eslint-plugin-react@7.34.1" has incorrect peer dependency "eslint@^3 || ^4 || ^5 || ^6 || ^7 || ^8".
warning " > eslint-plugin-react-hooks@4.6.2" has incorrect peer dependency "eslint@^3.0.0 || ^4.0.0 || ^5.0.0 || ^6.0.0 || ^7.0.0 || ^8.0.0-0".

Signed-off-by: George <bulakh.96@gmail.com>
Signed-off-by: George <bulakh.96@gmail.com>
@Karakatiza666 Karakatiza666 merged commit 30f4978 into main May 14, 2024
4 of 5 checks passed
@Karakatiza666 Karakatiza666 deleted the ui-deps branch May 14, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code Web Console Related to the browser based UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants