Skip to content

Commit

Permalink
E2E: put all the l2 service status tests under the L2ServiceStatus label
Browse files Browse the repository at this point in the history
We must be able to skip those tests out until
metallb#2311 is fixed.

Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
  • Loading branch information
fedepaol committed Mar 7, 2024
1 parent be4e909 commit c7eab49
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 3 deletions.
2 changes: 1 addition & 1 deletion e2etest/l2tests/interface_selector.go
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ var _ = ginkgo.Describe("L2-interface selector", func() {
framework.ExpectNoError(err)
})

ginkgo.It("Validate ServiceL2Status interface", func() {
ginkgo.It("Validate L2ServiceStatus interface", func() {
ginkgo.By("use the 1st interface for announcing")
resources := config.Resources{
L2Advs: []metallbv1beta1.L2Advertisement{
Expand Down
12 changes: 10 additions & 2 deletions e2etest/l2tests/l2.go
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,15 @@ var _ = ginkgo.Describe("L2", func() {
gomega.Eventually(func() error {
return service.ValidateL2(svc)
}, 2*time.Minute, 1*time.Second).ShouldNot(gomega.HaveOccurred())
})

ginkgo.It("should expose the status as L2ServiceStatus", func() {
svc, _ := service.CreateWithBackend(cs, f.Namespace.Name, "external-local-lb", service.TrafficPolicyCluster)

defer func() {
err := cs.CoreV1().Services(svc.Namespace).Delete(context.TODO(), svc.Name, metav1.DeleteOptions{})
framework.ExpectNoError(err)
}()

ginkgo.By("checking correct serviceL2Status object is populated")

Expand Down Expand Up @@ -800,9 +809,8 @@ var _ = ginkgo.Describe("L2", func() {
Name: fmt.Sprintf("test-addresspool%d", i+1),
},
Spec: metallbv1beta1.IPAddressPoolSpec{
Addresses: []string{addressesRange},
Addresses: []string{addressesRange},
AutoAssign: &autoAssign,

},
}
pools = append(pools, pool)
Expand Down

0 comments on commit c7eab49

Please sign in to comment.