fix: Added Pagination & Updated sidebar with counts

[jagadeeshgade008]

• added pagination for features,attributes, segments
• updated nav bar to side in desktop UI along with counts

[fahad19]

thanks so much for the PR, @jagadeeshgade008!

for awareness, since #274 we have a revision number that is numeric.

do you have any opinion where to put this info?

my suggestions (which you can reject):

• keep the top bar like we had before, and also keep the new sidebar
• on top bar's right side, include the revision info and also a button that links to the Git repo

this does lead to more design related questions, but I am open to hearing your feedback first.

[jagadeeshgade008]

@fahad19 How about adding the version number in the left sidebar bottom instead of adding two different menus

[fahad19]

@jagadeeshgade008: that could work too 👍

[jagadeeshgade008]

@fahad19 How can we get the version number
I have tried building the static site it is not available in search-index.json

[fahad19]

I believe a bit of extra work would be needed to make it available in generated search-index.json:

• extend the SearchIndex type to include a new revision: string property: https://github.com/featurevisor/featurevisor/blob/main/packages/types/src/index.ts#L441
• when generating content for search index, populate the result with new revision value: https://github.com/featurevisor/featurevisor/blob/main/packages/core/src/site/generateSiteSearchIndex.ts#L202
  • this can be done using datasource.readRevision() method: https://github.com/featurevisor/featurevisor/blob/main/packages/core/src/datasource/datasource.ts#L46

[jagadeeshgade008]

@fahad19 updated revision Can you review this

[fahad19]

👍

[fahad19]

👍

[jagadeeshgade008]

@fahad19 updated code changes