Skip to content

Commit

Permalink
Column limits in preview (#1182)
Browse files Browse the repository at this point in the history
  • Loading branch information
sdreyer committed Nov 30, 2023
1 parent b260828 commit 44ff460
Showing 1 changed file with 12 additions and 2 deletions.
14 changes: 12 additions & 2 deletions metadata/dashboard/dashboard_metadata.go
Original file line number Diff line number Diff line change
Expand Up @@ -1041,6 +1041,8 @@ type SourceDataResponse struct {
Stats []ColumnStat `json:"stats"`
}

const MaxPreviewCols = 15

func (m *MetadataServer) GetSourceData(c *gin.Context) {
name := c.Query("name")
variant := c.Query("variant")
Expand Down Expand Up @@ -1069,15 +1071,23 @@ func (m *MetadataServer) GetSourceData(c *gin.Context) {
return
}
dataRow := []string{}
for _, rowElement := range sRow.Rows {
for i, rowElement := range sRow.Rows {
dataRow = append(dataRow, extractElementValue(rowElement))
if i == MaxPreviewCols {
dataRow = append(dataRow, "")
break
}
}
response.Rows = append(response.Rows, dataRow)
}

for _, columnName := range iter.Columns() {
for i, columnName := range iter.Columns() {
cleanName := strings.ReplaceAll(columnName, "\"", "")
response.Columns = append(response.Columns, cleanName)
if i == MaxPreviewCols {
response.Columns = append(response.Columns, fmt.Sprintf("%d More Columns...", len(iter.Columns())-MaxPreviewCols))
break
}
}

//intentional
Expand Down

0 comments on commit 44ff460

Please sign in to comment.