New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Moonraker and therefore Klipper #3168
Open
davidzwa
wants to merge
52
commits into
develop
Choose a base branch
from
feat/2797-support-moonraker-and-klippy-api-basics
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Support Moonraker and therefore Klipper #3168
davidzwa
wants to merge
52
commits into
develop
from
feat/2797-support-moonraker-and-klippy-api-basics
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
davidzwa
force-pushed
the
feat/2797-support-moonraker-and-klippy-api-basics
branch
6 times, most recently
from
May 3, 2024 12:55
edb85df
to
6af5ddf
Compare
davidzwa
force-pushed
the
feat/2797-support-moonraker-and-klippy-api-basics
branch
3 times, most recently
from
May 7, 2024 18:30
11c227d
to
01bb7a5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3168 +/- ##
===========================================
+ Coverage 67.71% 68.58% +0.86%
===========================================
Files 214 224 +10
Lines 8664 8880 +216
Branches 1055 1155 +100
===========================================
+ Hits 5867 6090 +223
+ Misses 2796 2789 -7
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…mplify socket login, cleanup octoprint websocket state
…rder, fix test printerType
…to printer type octoprint
davidzwa
force-pushed
the
feat/2797-support-moonraker-and-klippy-api-basics
branch
from
May 9, 2024 09:11
5b09c14
to
34ad403
Compare
…t event processing into socket adapter instead of events cache
…pact state tracking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation
printerApi
dependency)printerResolveMiddleware
to use newprinterApi:IPrinterApi
scoped dependencyPrinterFilesStore
to use PrinterApiFactory for non-scoped PrinterApicurrent
to a similar formatcurrent
conversion into socket adapterMinimum happy flow tests (acceptance criteria):
Unhappy flow tests:
Beta release actions: