feat(scheduler): enhance sector's financials sync

Author: fcote

scheduler/internal/repository/pg/financial.go

@@ -3,6 +3,7 @@ package pg
 import (
 	"context"
 	"fmt"
+	"sort"
 
 	"github.com/fcote/merlin/sheduler/internal/domain"
 	"github.com/fcote/merlin/sheduler/pkg/gmonitor"
@@ -229,5 +230,14 @@ where c.sector_id = $1;
 		return nil, fmt.Errorf("could not read financial period rows: %w", err)
 	}
 
+	sort.Slice(periods, func(i, j int) bool {
+		yearI := periods[i].Year
+		yearJ := periods[j].Year
+		if yearI != yearJ {
+			return yearI < yearJ
+		}
+		return periods[i].Period > periods[j].Period
+	})
+
 	return periods, nil
 }

scheduler/internal/usecase/financial_sector.go

@@ -2,10 +2,8 @@ package usecase
 
 import (
 	"context"
+	"errors"
 	"fmt"
-	"runtime"
-
-	"github.com/sourcegraph/conc/pool"
 
 	"github.com/fcote/merlin/sheduler/internal/domain"
 	"github.com/fcote/merlin/sheduler/pkg/glog"
@@ -14,8 +12,6 @@ import (
 	"github.com/fcote/merlin/sheduler/pkg/pointer"
 )
 
-var sectorFinancialConcurrency = runtime.GOMAXPROCS(0)
-
 type sectorJob struct {
 	sector domain.Sector
 	year   int
@@ -49,30 +45,15 @@ func (uc FinancialSectorUsecase) SyncSectorFinancials(ctx context.Context, secto
 		return fmt.Errorf("%s | could not fetch sector financial periods: %w", sector.Name, err)
 	}
 
-	p := pool.New().
-		WithErrors().
-		WithContext(ctx).
-		WithMaxGoroutines(sectorFinancialConcurrency)
-
-	uc.launchSyncs(p, sector, sectorPeriods)
-
-	if err := p.Wait(); err != nil {
-		return err
-	}
-
-	return nil
-}
-
-func (uc FinancialSectorUsecase) launchSyncs(pool *pool.ContextPool, sector domain.Sector, sectorPeriods []domain.FinancialYearPeriod) {
 	for _, period := range sectorPeriods {
-		pool.Go(func(ctx context.Context) error {
-			return uc.sync(ctx, sectorJob{
-				sector: sector,
-				year:   period.Year,
-				period: period.Period,
-			})
-		})
+		err = errors.Join(err, uc.sync(ctx, sectorJob{
+			sector: sector,
+			year:   period.Year,
+			period: period.Period,
+		}))
 	}
+
+	return err
 }
 
 func (uc FinancialSectorUsecase) sync(ctx context.Context, job sectorJob) error {

scheduler/internal/usecase/financial_ttm.go

@@ -100,7 +100,7 @@ func last4QuartersMap(financials domain.Financials, financialItemMap map[int]dom
 
 	for _, financial := range financials {
 		// Only store quarters financials
-		if financial.Period == domain.FinancialPeriodY {
+		if !financial.Period.IsQuarter() {
 			continue
 		}
 		fi := financialItemMap[financial.FinancialItemId]