New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multi-parameter println spacing #228
Conversation
`fmt.Println` will add spaces between elements when there is multiple parameters sent. When wrapping the colors parameters were combined using `fmt.Sprint(a...)` - which does not space out parameters. Use `fmt.Sprintln` to combine parameters. Fixes fatih#218
Thank you @klauspost for the fix. How important is a release for you? I was planning to wait a few weeks before releasing a new version. |
@fatih Not very, as it is cosmetic. I can always pin the master commit. Feel free to keep it for the RGB release. |
Got it, thank you again. Feel free to ping me If I forgot the release. |
@fatih Gentle ping. |
@klauspost, thanks for the ping. Released a new version https://github.com/fatih/color/releases/tag/v1.17.0 |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/fatih/color](https://togithub.com/fatih/color) | `v1.16.0` -> `v1.17.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2ffatih%2fcolor/v1.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2ffatih%2fcolor/v1.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2ffatih%2fcolor/v1.16.0/v1.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2ffatih%2fcolor/v1.16.0/v1.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fatih/color (github.com/fatih/color)</summary> ### [`v1.17.0`](https://togithub.com/fatih/color/releases/tag/v1.17.0) [Compare Source](https://togithub.com/fatih/color/compare/v1.16.0...v1.17.0) #### What's Changed - Fix multi-parameter println spacing by [@​klauspost](https://togithub.com/klauspost) in [fatih/color#228 - ci: update Go and Staticcheck versions by [@​fatih](https://togithub.com/fatih) in [fatih/color#222 - Bump golang.org/x/sys from 0.14.0 to 0.17.0 by [@​dependabot](https://togithub.com/dependabot) in [fatih/color#221 - Bump actions/setup-go from 4 to 5 by [@​dependabot](https://togithub.com/dependabot) in [fatih/color#217 - Bump golang.org/x/sys from 0.17.0 to 0.18.0 by [@​dependabot](https://togithub.com/dependabot) in [fatih/color#224 #### New Contributors - [@​klauspost](https://togithub.com/klauspost) made their first contribution in [fatih/color#228 **Full Changelog**: fatih/color@v1.16.0...v1.17.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/anoriqq/qpm). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNTEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjM1MS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/fatih/color](https://togithub.com/fatih/color) | `v1.16.0` -> `v1.17.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2ffatih%2fcolor/v1.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2ffatih%2fcolor/v1.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2ffatih%2fcolor/v1.16.0/v1.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2ffatih%2fcolor/v1.16.0/v1.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fatih/color (github.com/fatih/color)</summary> ### [`v1.17.0`](https://togithub.com/fatih/color/releases/tag/v1.17.0) [Compare Source](https://togithub.com/fatih/color/compare/v1.16.0...v1.17.0) #### What's Changed - Fix multi-parameter println spacing by [@​klauspost](https://togithub.com/klauspost) in [fatih/color#228 - ci: update Go and Staticcheck versions by [@​fatih](https://togithub.com/fatih) in [fatih/color#222 - Bump golang.org/x/sys from 0.14.0 to 0.17.0 by [@​dependabot](https://togithub.com/dependabot) in [fatih/color#221 - Bump actions/setup-go from 4 to 5 by [@​dependabot](https://togithub.com/dependabot) in [fatih/color#217 - Bump golang.org/x/sys from 0.17.0 to 0.18.0 by [@​dependabot](https://togithub.com/dependabot) in [fatih/color#224 #### New Contributors - [@​klauspost](https://togithub.com/klauspost) made their first contribution in [fatih/color#228 **Full Changelog**: fatih/color@v1.16.0...v1.17.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/hetznercloud/cli). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNTEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjM1MS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/fatih/color](https://togithub.com/fatih/color) | `v1.16.0` -> `v1.17.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2ffatih%2fcolor/v1.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2ffatih%2fcolor/v1.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2ffatih%2fcolor/v1.16.0/v1.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2ffatih%2fcolor/v1.16.0/v1.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>fatih/color (github.com/fatih/color)</summary> ### [`v1.17.0`](https://togithub.com/fatih/color/releases/tag/v1.17.0) [Compare Source](https://togithub.com/fatih/color/compare/v1.16.0...v1.17.0) #### What's Changed - Fix multi-parameter println spacing by [@​klauspost](https://togithub.com/klauspost) in [fatih/color#228 - ci: update Go and Staticcheck versions by [@​fatih](https://togithub.com/fatih) in [fatih/color#222 - Bump golang.org/x/sys from 0.14.0 to 0.17.0 by [@​dependabot](https://togithub.com/dependabot) in [fatih/color#221 - Bump actions/setup-go from 4 to 5 by [@​dependabot](https://togithub.com/dependabot) in [fatih/color#217 - Bump golang.org/x/sys from 0.17.0 to 0.18.0 by [@​dependabot](https://togithub.com/dependabot) in [fatih/color#224 #### New Contributors - [@​klauspost](https://togithub.com/klauspost) made their first contribution in [fatih/color#228 **Full Changelog**: fatih/color@v1.16.0...v1.17.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 4pm on thursday" in timezone America/Los_Angeles, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/scottames/dots). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjMuNSIsInVwZGF0ZWRJblZlciI6IjM3LjM2My41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
fmt.Println
will add spaces between elements when there is multiple parameters sent. This is also described in the documentation of this library:Spaces are always added between operands and a newline is appended.
When wrapping the colors parameters were combined using
fmt.Sprint(a...)
- which does not space out parameters.Use
fmt.Sprintln
to combine parameters.Fixes #218