New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RGB API support #225
base: main
Are you sure you want to change the base?
Add RGB API support #225
Conversation
Signed-off-by: Fatih Arslan <ftharsln@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thanks 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple nitpicks on the comments but, LGTM 🚀
API seems straightforward and easy to use. It's a great addition to the existing supported ANSI color palette.
Thanks for picking this up 👍🏼
Co-authored-by: Bruno Schaatsbergen <git@bschaatsbergen.com>
Thanks for to the reviews. I want to keep this open for some time to try it out before I merge it. |
This PR adds support for a new RGB API to allow to print 24-bit colors. Opening for feedback, and will probably merge it as it is. If anyone wants to try it out, check the
TestRGB
test case or the newly added README.md docs.