Move codecov push to its own job in Actions workflow #502
Conversation
Remove the push to codecov step from the `test` job into a new job that depends on the test job. Upload the coverage report as an artifact after testing, and reuse that artifact in the new job. Only the coverage from the ubuntu runner with the latest dependencies is uploaded to minimize hits to codecov.
Try to see if this downloads the artifact and decompress it in the root of the git repo.
Upload coverage report obtained by ubuntu with optional dependencies.
santisoler
changed the title
There was a problem hiding this comment.
Nice! For Harmonica this will work great but for other packages that have optional dependencies, the full coverage is only obtained when merging reports from multiple jobs. Then this won't work. Do you think it would be possible to upload artifacts for all of the jobs?
|
I think we can. We would just have to name each artifact differently and then download them all and pushed them all in a single job. Does it make sense? |
|
👍🏾 |
Simplify dir structure of downloaded artifacts. Improve comments.
Since we are uploading all files at once, we don't need to keep track from which runner each one of them was generated.
This way we avoid having artifacts names `coverage-ubuntu-latest-latest` that could be confusing. This artifact would be now `coverage_ubuntu-latest_latest`.
|
Done! Now all runners upload the Let me know if you like it. I'm looking forward to try this out on a PR opened from a fork. |
Remove the push to codecov step from the
testjob into a new job that depends on the test job. Upload the coverage report as an artifact after testing, and reuse that artifact in the new job. Only the coverage from the ubuntu runner with the latest dependencies is uploaded to minimize hits to codecov.Relevant issues/PRs:
Related to fatiando/community#151