Bump minimum version of Numpy to 1.22 #496
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try to see if the patch can be built in MacOS. Before this, CI was trying to install Numpy 1.22.0.
|
The issue this PR was trying to solve was fixed by #499 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numpy dropped support for the 1.21 version on Jun 23, 2023. Running the
Harmonica tests in MacOS with Python 3.8 and Numpy v1.21 was impossible
because of installation error of Numpy using
pip.Lets see if with this new version the issue is resolved.
Relevant issues/PRs: