Add tilt transformation #486
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added `tilt` function to `_transformations.py` * added it to the `index.rst` * created an example in `tilt.py` * added it to `__init__.py` * added the class `TestTilt` in `test_transformations.py`; however, the test is failling.
For some reason that I don't know the test of tilt passes when you change the sinal of g_z in `TestTilt:test_against_synthetic` in `test_transformations.py`
leouieda
requested changes
Apr 15, 2024
There was a problem hiding this comment.
Thanks for this @leomiquelutti! Made a few comments but nothing major. Good work!
Co-authored-by: Leonardo Uieda <leo@uieda.com>
|
Do you know why the test for macOS for python 3.8 is failing and/or how to solve it, @leouieda? |
|
It was due to a failure when trying to push the coverage report to Codecov. I reran it and now it's passing. Nothing wrong with your code ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed:
tiltfunction to_transformations.pyindex.rsttilt.py__init__.pyTestTiltintest_transformations.pySome points/questions:
TestTilt::test_against_syntheticis failing and I don't know why.tilt.pyrequire a title. I added but had a hard time with pyGMT, so I left them commented..pyfile, comparing the transformations from TMI to the ones from RTP TMI. But that should be done in another PR.transformations.rst?Can you please help me @santisoler.