Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add protection for when kernel_quantizer is None #997

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jmitrevs
Copy link
Contributor

Description

The hls4ml software assumes that in QKeras, QDense, QConv, etc, will always have kernel_quantizer or similar defined. This fixes the case when they are not, as found in issue #990.

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Tests

Must first check that this doesn't break other tests. Whether we want to add a test for this particular situation I am not sure.

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.
  • I have added tests that prove my fix is effective or that my feature works.

@jmitrevs jmitrevs changed the title add protection for when kernel_quanitzer is None add protection for when kernel_quantizer is None Apr 12, 2024
@jmitrevs jmitrevs added the bug label Apr 12, 2024
@vloncar vloncar added the please test Trigger testing by creating local PR branch label Apr 19, 2024
@jmitrevs jmitrevs added please test Trigger testing by creating local PR branch and removed please test Trigger testing by creating local PR branch labels May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug please test Trigger testing by creating local PR branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants