Add namespaces and optional writer config #986
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As observed in the emulator in CMSSW, there are some issues with global namespace being polluted when multiple versions of the same model are loaded. The accepted solution was to use namespaces. This PR follows up in hls4ml by adding the ability to generate namespace and optionally not write .txt files (also requested by the emulator people) and not to write .tar.gz (everyone hates this). The new configurable options are placed under
WriterConfig
as it made no sense to shove them underHLSConfig
. In the future with the new config scheme we will re-evaluate this.Type of change
Tests
There's a test in
test_writer_config.py
for the 3 new config optionsChecklist
pre-commit
on the files I edited or added.