-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hls4ml Optimization API [Part 2] #809
base: main
Are you sure you want to change the base?
hls4ml Optimization API [Part 2] #809
Conversation
I will add pre-commit additionally, last time I ran it, some tests were broken, so will add it a subsequent commit. |
This is ready for review, seems that pre-commit can re-arrange the order of includes in C++ header files and it could cause compilation error. |
20ed996
to
0f0adc4
Compare
We merged part 1. Should we merge part 2? |
I'm reviewing it. Slowly 😃 . But it's next in line, then HGQ. |
The pytest error is unrelated to the PR so from my side this can be merged. I'll let Vladimir give the last OK. |
Description
Type of change
Tests
Checklist
pre-commit
on the files I edited or added.