SepConv1d/2d for io_parallel with Latency strategy #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmitrevs
added
please test
jmitrevs
added
please test
jmitrevs
added
please test
jmitrevs
added
please test
|
@dgburnette This could be followed up in Catapult. I noticed that you don't use the code-gen im2col implementations of conv1d/2d so I didn't want to mess with it |
jmitrevs
reviewed
Jun 5, 2024
| elif '2D' in node_class: | ||
| self._generate_im2col_2d(node) | ||
| node_class = node.class_name | ||
| if 'Separable' in node_class: |
There was a problem hiding this comment.
If we just had DepthwiseConv2D (https://keras.io/api/layers/convolution_layers/depthwise_convolution2d/) would this work? We nominally support it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds implementation of
SeparableConv1D/2Dforio_parallelandLatencystrategy. It's based on existing code-generation forConv1D/2D.Type of change
Tests
Added tests in
test_sepconv1d.pyandtest_sepconv2d.py. 1D tests had a nonsense test with a kernel size of 1, I changed that to 2 to be in line with the 2D tests.Checklist
pre-commiton the files I edited or added.