Update for Fastify v5 #957
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
created and rebased |
|
tests are broken |
I think we need to drop node 14 and 16 for this one |
it was always part of the original plan, wasn't it? fastify/fastify#5116
|
simoneb
reviewed
Mar 21, 2024
simoneb
approved these changes
Mar 21, 2024
gurgunday
reviewed
Apr 14, 2024
| @@ -1,6 +1,4 @@ | |||
| 100: true | |||
There was a problem hiding this comment.
Just one question:
Why did we go to disable-coverage from 100?
Maybe it works without disable-coverage?
|
Hey, can you pull form main? I can't realistically resolve the package-lock conflicts on the web interface... And if you could also add node 22 to the test matrix it would be great Then this is good to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: fastify/fastify#5116
basePathoption. Even thought thebasePathis still present in their config docs and typings it does not work. I am unsure if this doc saying that it was removed might have something to do with this issue.I am open to discuss what would be the best way to fix this one.
Checklist
npm run testandnpm run benchmarkand the Code of conduct
CC @simoneb