Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #69 Visual Studio Code does not render progress bars corr… #70

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hsm
Copy link

@hsm hsm commented Sep 4, 2020

…ectly

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

@jph00
Copy link
Member

jph00 commented May 20, 2022

sorry @hsm I only just saw this. it's a good idea, although it means that fastprogress won't work unless ipywidgets is installed. how about only using ipywidgets in the case where the user is on vscode?

BTW, you need to nbdev_install_git_hooks to ensure you have a clean NB in your PR.

@guillochon
Copy link

Hi, I hit this bug in VSCode and used the monkeypatch @hsm wrote in this post here to fix it:

from IPython.display import clear_output, DisplayHandle
def update_patch(self, obj):
    clear_output(wait=True)
    self.display(obj)
DisplayHandle.update = update_patch

Any chance some sort of fix can be merged into the main branch? It's been impacting quite a few users I think for over 2 years now.

@codewithcheese
Copy link

codewithcheese commented Mar 21, 2023

@guillochon note that progress bars were working in VSCode and only stopped a few days ago. This is an old PR that I guess was fixed in a different way. Here is the new issue #104

Either way your workaround is useful for the current issue, thanks. You may want to post your workaround on the issue, it is closer to the intended output than the suggestions.

@codermrrob
Copy link

#104 now has some specific detail in this comment thanks to @bosmart, https://github.com/fastai/fastprogress/issues/104#issuecomment-1482350888

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants