Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3901 - Added Guards for Pickling Losses #3910

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+32 −0
Open

#3901 - Added Guards for Pickling Losses #3910

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
32 changes: 32 additions & 0 deletions nbs/01a_losses.ipynb
View file
Open in desktop
Expand Up @@ -831,6 +831,38 @@
"_ = cl(output, target)"
]
},
{
"cell_type": "code",
"execution_count": null,
"metadata": {},
"outputs": [],
"source": [
"# Tests to catch future changes to pickle which cause some loss functions to be 'unpicklable'.\n",
"# This causes problems with `Learner.export` as the model can't be pickled with these particular loss funcitons.\n",
"\n",
"losses_picklable = [\n",
" (BCELossFlat(), True),\n",
" (BCEWithLogitsLossFlat(), True),\n",
" (CombinedLoss(), False),\n",
" (CrossEntropyLossFlat(), True),\n",
" (DiceLoss(), False),\n",
" (FocalLoss(), True),\n",
" (FocalLossFlat(), False),\n",
" (L1LossFlat(), True),\n",
" (LabelSmoothingCrossEntropyFlat(), False),\n",
" (LabelSmoothingCrossEntropy(), True),\n",
" (MSELossFlat(), True),\n",
"]\n",
"\n",
"for loss, picklable in losses_picklable:\n",
" try:\n",
" pickle.dumps(loss, protocol=2)\n",
" except (pickle.PicklingError, TypeError) as e:\n",
" if picklable:\n",
" # Loss was previously picklable but isn't currently\n",
" raise e"
]
},
{
"cell_type": "markdown",
"metadata": {},
Expand Down