Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add learner.predict() usage example #3842

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bencoman
Copy link

2022 Part 1 Lesson 1 has the following example which throws away the middle return value, which is useful when students start doing their own experiments when the predicted answer is not probs[0].

image

but as pointed out here: https://forums.fast.ai/t/how-to-output-confidence-of-classiifcation-models/102221?u=bencoman
the documentation is not clear on how to use that middle return value - so adding a beginner example to the doc (not sure if this is the best way to do this.)

@bencoman bencoman requested a review from jph00 as a code owner November 27, 2022 06:20
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@bencoman
Copy link
Author

I'm not sure why this dff showed up. I didn't consciously make a change there.
image

@bencoman bencoman force-pushed the learner-predict-doc branch 2 times, most recently from 8c5074b to 4b47af2 Compare November 27, 2022 06:25
@jph00
Copy link
Member

jph00 commented Nov 27, 2022

Many thanks @bencoman . I think you need a blank line before your list to make it appear correctly. I suggest removing the name of each output, since they don't really have names (it's an unnamed tuple). Also you might want to add the with_input optional output to the list.

@jph00
Copy link
Member

jph00 commented Mar 26, 2023

Closing due to lack of activity - @bencoman feel free to reopen if you have a chance to get back to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants