Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed FancyShowCaseView not hiding for CUSTOM VIEW #169

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed FancyShowCaseView not hiding for CUSTOM VIEW #169

wants to merge 2 commits into from

Conversation

Rajnish23
Copy link
Contributor

Fixes #161

@faruktoptas
Copy link
Owner

The root cause of this problem should be solved from the library not the sample. FancyImageView is added multiple times. It should be fixed.

@Rajnish23
Copy link
Contributor Author

The root cause of this problem should be solved from the library not the sample. FancyImageView is added multiple times. It should be fixed.

I have made changes in library. Please review it.

AdrianLxM
AdrianLxM reviewed Dec 20, 2019
View reviewed changes
fancyshowcaseview/src/main/java/me/toptas/fancyshowcase/FancyShowCaseView.kt
@@ -902,6 +902,9 @@ class FancyShowCaseView @JvmOverloads constructor(context: Context, attrs: Attri
* @return [FancyShowCaseView] with given parameters
*/
fun build(): FancyShowCaseView {
if(isVisible(activity)){
hideCurrent(activity)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I like the idea of auto-hiding, yet shouldn't this be done in the show() function. The build() function would also be used to prepare show cases to be enqueued e.g..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I do agree this should be done inside show() function instead of the build method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdrianLxM AdrianLxM AdrianLxM left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FancyShowCaseView not hiding
3 participants
@Rajnish23 @faruktoptas @AdrianLxM