Change value field match conditions in jazzmin_list_filter template tag #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tura0
approved these changes
Feb 10, 2023
JMSoler7
approved these changes
Feb 10, 2023
n1ngu
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR solves Issue #479
The problem appears when 2 list filters can match between them in
key.startswith(field_key + "__")condition.In order to prevent this i added a condition to check on count of string "__" in both key and field_key variables.
I don't know if it's the best solution or even if works with all existing use cases as i don't know them all and couldn't find one where it goes wrong.