Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 422 error during provisioning of Circle CI source #342

Merged
merged 1 commit into from Mar 20, 2024

Conversation

thomas-gerber
Copy link
Contributor

Description

Adjust circle CI source config for breaking change in spec.
Breaking changes on the source were introduced this PR.

Type of change

(Delete what does not apply)

  • Bug fix (non-breaking change which fixes an issue)

Checklist

(Delete what does not apply)

  • Have you checked if there aren't other open Pull Requests for the same update/change?
  • Have you lint your code locally before submission?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Breaking changes on the source were introduced [this PR](faros-ai/airbyte-connectors#1268).
@thomas-gerber
Copy link
Contributor Author

@willmarks do you know what happens for existing CE users that use Circle CI and that update the source? How is the spec change handled Airbyte-side?

@thomas-gerber
Copy link
Contributor Author

I think we were somewhat lucky the PR integration tests worked with the current bad image, because GitHub was provisioned successfully before the 422, and the integration test is on GitHub data.

@tovbinm tovbinm merged commit 0d618a1 into main Mar 20, 2024
2 checks passed
@tovbinm tovbinm deleted the circleci_provisioning_fix branch March 20, 2024 15:57
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants