Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single compose file #214

Merged
merged 3 commits into from Oct 5, 2022
Merged

Single compose file #214

merged 3 commits into from Oct 5, 2022

Conversation

thomas-gerber
Copy link
Contributor

@thomas-gerber thomas-gerber commented Oct 3, 2022

Description

On windows, one sees local volume related errors (see #173 and this slack thread). However, we noticed that:

  1. on that same machine, one could start vanilla airbyte with docker compose (see airbyte documentation)
  2. on that same machine, docker-compose -f airbyte-services.yaml up did not have any volume issues (i.e. airbyte-server got successfully created.

Hence, there may be some issues with the extends keyword, which is not surprising given its checkered history (here, and here).

The fix is to group everything into a single compose file.
Fixes #173

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

(Delete what does not apply)

  • Have you checked to there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

@thomas-gerber
Copy link
Contributor Author

Currently being tested by a windows user.

@thomas-gerber
Copy link
Contributor Author

Tested on

  • Windows 10.0.19044 (Windows 10 Pro)
  • Docker Desktop for Windows 4.12.0 (85629) with WSL2 as doc suggests (I was prompted by docker desktop to do this
    Ingested some data.
    It works!

@thomas-gerber thomas-gerber added bug Something isn't working and removed DO NOT MERGE work in progress labels Oct 5, 2022
@thomas-gerber thomas-gerber self-assigned this Oct 5, 2022
@thomas-gerber
Copy link
Contributor Author

@ypc-faros could you check if I got the profiles correct?

Copy link
Contributor

@tovbinm tovbinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Let's put comments around the section from the original Airbyte compose file so it would be easier for us to merge with upstream later on.

@thomas-gerber
Copy link
Contributor Author

Awesome!

Let's put comments around the section from the original Airbyte compose file so it would be easier for us to merge with upstream later on.

Already done

@ypc-faros
Copy link
Contributor

@ypc-faros could you check if I got the profiles correct?

Looks good 👍

@thomas-gerber thomas-gerber merged commit 16ec572 into main Oct 5, 2022
@thomas-gerber thomas-gerber deleted the single_compose branch October 5, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to install faros on windows OS
3 participants