Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ci action for checking types and running the build #12

Merged
merged 2 commits into from
May 12, 2023
Merged

add ci action for checking types and running the build #12

merged 2 commits into from
May 12, 2023

Conversation

Simon-Laux
Copy link
Collaborator

@Simon-Laux Simon-Laux commented May 12, 2023 •
edited

to make sure you did not break it with your commit/pr

completes the migration to typescript, closes #8

@Simon-Laux Simon-Laux requested a review from farooqkz May 12, 2023 14:27
farooqkz
farooqkz approved these changes May 12, 2023
View reviewed changes
Copy link
Owner

@farooqkz farooqkz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@farooqkz farooqkz merged commit 16ed78a into master May 12, 2023
1 check passed
@farooqkz farooqkz deleted the github_ci_for_typescript branch May 12, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farooqkz farooqkz farooqkz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to Typescript
2 participants
@Simon-Laux @farooqkz