Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): don't write to source directory during build #1034

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gnosek
Copy link
Contributor

@gnosek gnosek commented Apr 7, 2023

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap-engine-udig

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

This patch makes it possible to build the libs from a read-only directory (like in a container).

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@poiana
Copy link
Contributor

poiana commented Apr 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnosek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Andreagit97
Copy link
Member

The fix is completely reasonable! The bpf probe compilation seems broken because we still search this file into the source dir

@FedeDP
Copy link
Contributor

FedeDP commented May 3, 2023

@gnosek can you fix this?

@FedeDP
Copy link
Contributor

FedeDP commented May 3, 2023

/milestone 0.12.0

@poiana poiana added this to the 0.12.0 milestone May 3, 2023
@FedeDP
Copy link
Contributor

FedeDP commented May 3, 2023

Could be moved to 0.11.0 if Grzeg's response is quick :D

@Andreagit97 Andreagit97 modified the milestones: 0.12.0, driver-backlog Jun 7, 2023
@leogr
Copy link
Member

leogr commented Aug 10, 2023

Could we revamp this? 🤔

Signed-off-by: Grzegorz Nosek <grzegorz.nosek@sysdig.com>
@FedeDP
Copy link
Contributor

FedeDP commented Sep 13, 2023

TODO for me: double check that this does not break driverkit builds.

@incertum
Copy link
Contributor

incertum commented Feb 6, 2024

Hi @gnosek and @FedeDP just kindly checking in on the status of this PR. When do you all think we should work on it? Thank you!

@FedeDP
Copy link
Contributor

FedeDP commented Feb 7, 2024

Well, for #1452 i wrote a patch for driverkit to let it build through CMake: falcosecurity/driverkit#302
Once that is merged, we have no more blockers (driverkit side) for this one.

@FedeDP
Copy link
Contributor

FedeDP commented Feb 7, 2024

Same goes for #1188 !

@incertum
Copy link
Contributor

incertum commented Feb 7, 2024

Thanks for providing an update @FedeDP 🙏

@poiana
Copy link
Contributor

poiana commented May 7, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@leogr
Copy link
Member

leogr commented May 7, 2024

/remove-lifecycle stale

Hey @gnosek any update on this? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants