Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docco): Add Homebrew as a MacOS install option #495

Merged
merged 1 commit into from Mar 25, 2024

Conversation

mapkon
Copy link
Contributor

@mapkon mapkon commented Mar 25, 2024

What type of PR is this?

/kind documentation

What this PR does / why we need it:

This PR advertises the fact that falcoctl can easily be installed via the Homebrew package manager

Which issue(s) this PR fixes:

Fixes #494

Special notes for your reviewer:

Signed-off-by: Mark Gerard <kata.mapkon@gmail.com>
@poiana
Copy link
Contributor

poiana commented Mar 25, 2024

@mapkon: The label(s) area/documentation cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind documentation

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area documentation

What this PR does / why we need it:

This PR advertises the fact that falcoctl can easily be installed via the Homebrew package manager

Which issue(s) this PR fixes:

Fixes #494

Special notes for your reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana requested review from alacuku and loresuso March 25, 2024 07:15
@poiana
Copy link
Contributor

poiana commented Mar 25, 2024

Welcome @mapkon! It looks like this is your first PR to falcosecurity/falcoctl 🎉

@poiana poiana added the size/XS label Mar 25, 2024
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

can you please rebase?

thanks

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Thanks!

@poiana
Copy link
Contributor

poiana commented Mar 25, 2024

LGTM label has been added.

Git tree hash: d86fce0e934733ca2511c86722c7c34288f63edc

@poiana
Copy link
Contributor

poiana commented Mar 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, mapkon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit a89aa89 into falcosecurity:main Mar 25, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add homebrew as an install option
4 participants