Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: adding new event of copying content of sensitive files #99

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

h4l0gen
Copy link
Contributor

@h4l0gen h4l0gen commented Mar 13, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind documentation

/kind tests

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area commands

/area pkg

/area events

What this PR does / why we need it:
This PR is adding an event which will try to copy content of sensitive files to another destination.
Which issue(s) this PR fixes:

Fixes #96

Special notes for your reviewer:

Signed-off-by: h4l0gen <ks3913688@gmail.com>
@poiana
Copy link

poiana commented Mar 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: h4l0gen
Once this PR has been reviewed and has the lgtm label, please assign fededp for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Mar 13, 2024

Welcome @h4l0gen! It looks like this is your first PR to falcosecurity/event-generator 🎉

@poiana poiana added the size/M label Mar 13, 2024
@h4l0gen
Copy link
Contributor Author

h4l0gen commented Mar 13, 2024

Hey maintainers, this is my first PR for the event-generator. I've created an event for the first time, so please review the PR and provide me with your valuable feedback. Thank you!

@h4l0gen
Copy link
Contributor Author

h4l0gen commented Mar 13, 2024

/kind feature
/area events

@h4l0gen
Copy link
Contributor Author

h4l0gen commented Mar 13, 2024

/area events

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but I can't find any "Download Sensitive File" rule: https://github.com/falcosecurity/rules/tree/main/rules

Each action must match a specific existing rule and have the same name
(I apologize because I know this convention is not documented).

So my question is: which rule is this event targeting? 🤔

@h4l0gen
Copy link
Contributor Author

h4l0gen commented Mar 14, 2024

@leogr , oh i wasn't aware of this

Each action must match a specific existing rule and have the same name
(I apologize because I know this convention is not documented).

then this event doesn't belong to any specific rule. I just created it as per security concern.

@h4l0gen
Copy link
Contributor Author

h4l0gen commented Mar 14, 2024

@leogr i came across this rule Launch Remote file copy tools in container in https://falco.org/docs/reference/rules/default-rules/
this rule has also procedure of copying content of file. If you like i can convert this PR to Launch Remote file copy tools in container rule.

@h4l0gen h4l0gen changed the title adding new event of copying content of sensitive files wip: adding new event of copying content of sensitive files Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding New event copying_sensitive_file
3 participants