adding event for this rule mount launched in privileged container
#207
Conversation
|
In this event, flags are set syscall.CLONE_NEWNS | syscall.CLONE_NEWUSER as this action is in the privileged container. |
| Cloneflags: syscall.CLONE_NEWNS | syscall.CLONE_NEWUSER, | ||
| } | ||
|
|
||
| return cmd.Run() |
There was a problem hiding this comment.
Since cmd will always fail but it is enough to trigger the rule we might want to ignore the error and just return nil, wdyt?
There was a problem hiding this comment.
Yes @FedeDP, just return nil is also fine. As I've added err statement initially just to make clear that error will occur during this event. Can we add comment for this?
There was a problem hiding this comment.
Makes sense to add a small comment, yes!
Signed-off-by: h4l0gen <ks3913688@gmail.com> squashing commits Signed-off-by: h4l0gen <ks3913688@gmail.com>
h4l0gen
force-pushed
the
mountLaunchedInPrivilegedContainer
branch
from
1313c7a
to
afe083c
Compare
|
@FedeDP If everything looks good to you, then we are good to go with this PR. |
Co-authored-by: Federico Di Pierro <nierro92@gmail.com> Signed-off-by: Kapil Sharma <ks3913688@gmail.com>
|
@FedeDP changes done. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, h4l0gen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: ea44683f41d733400b2020195fdbec33155df70e
|
What type of PR is this?
Any specific area of the project related to this PR?
/area events
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #204
Special notes for your reviewer: