chore(tutorial): clean up & automate look tests #1611
Conversation
| @@ -1,3 +1,5 @@ | |||
| gunicorn==19.9.0 | |||
There was a problem hiding this comment.
Note that our recommended way to run the look example with gunicorn does not work on Gunicorn 20.0.0.
However, if I interpret benoitc/gunicorn#2175 correctly, a fix may be already in master or under way.
There was a problem hiding this comment.
For what it's worth, I generally import and use gunicorn directly in my apps when wrapping gunicorn. We might investigate doing that here as well.
There was a problem hiding this comment.
Yeah, that's generally a good approach. I have adopted it at work for some development servers (we use Nginx+uWSGI on prod though) as it's easy to toss in a static route, inject some dependencies or w/e needed for the dev environment when it is just Python code.
However, I'm not sure that's a good approach here in this "look" tutorial as we recommend running gunicorn like that and like that. We could of course improve that, but IMHO running gunicorn in the command line is arguably easier for new users. Plus, it's much easier to swap out command-line unicorn to something else, for instance, waitress for Windows folks etc.
Codecov Report
@@ Coverage Diff @@
## master #1611 +/- ##
======================================
Coverage 100% 100%
======================================
Files 40 40
Lines 2671 2671
Branches 395 395
======================================
Hits 2671 2671Continue to review full report at Codecov.
|
This PR builds further upon the look tutorial improvements delivered by @cravindra in #1558 , and aims to run these tests in Travis to make sure our tutorial stays valid.