Resolve devices by name only: #31 #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed the function and cleaned up my code some. |
|
Looks good. Could you rebase and squash into a single commit? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch addresses issue #31 :
ponymixnow resolves devices using only the name of the devices specified. The--sourceand--sinkkeywords are silently ignored. On the other hand, if no device is explicitly requested, the keywords will result in the name of the respective default device being queried. Actions are then taken based on the resulting name only.Note: targetting the monitor of a device by supplying it with the complement keyword is no longer possible. For example:
This used to target the source of the output device, which in this case has the full name
alsa_output.pci-0000_00_1b.0.analog-stereo.monitor. Maybe we could introduce a--monitorflag?