Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra(deps): remove unused glob #2891

Merged
merged 1 commit into from May 12, 2024
Merged

infra(deps): remove unused glob #2891

merged 1 commit into from May 12, 2024

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented May 11, 2024

It looks like we no longer use the glob dependency.

I searched for it and haven't found any usages of it, but please check as well.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: dependencies Pull requests that adds/updates a dependency c: infra Changes to our infrastructure or project setup labels May 11, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone May 11, 2024
@ST-DDT ST-DDT requested review from a team May 11, 2024 18:47
@ST-DDT ST-DDT self-assigned this May 11, 2024
Copy link

netlify bot commented May 11, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 1d64ccc
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/663fbd609848770008e3f918
😎 Deploy Preview https://deploy-preview-2891.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (bbdd998) to head (1d64ccc).

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2891   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files        2977     2977           
  Lines      215466   215466           
  Branches      600      597    -3     
=======================================
+ Hits       215366   215379   +13     
+ Misses        100       87   -13     

see 1 file with indirect coverage changes

@Shinigami92
Copy link
Member

It looks like we no longer use the glob dependency.

I searched for it and haven't found any usages of it, but please check as well.

it was part of the build script
however, glob is part of node v22 anyways, so when we need it, we can use it from there

@ST-DDT ST-DDT merged commit 428f4e9 into next May 12, 2024
25 checks passed
@ST-DDT ST-DDT deleted the infra/deps/glob branch May 12, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: dependencies Pull requests that adds/updates a dependency c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants