Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(locale): normalize company data #2889

Merged
merged 3 commits into from May 14, 2024

Conversation

xDivisionByZerox
Copy link
Member

Description

Follow-on to #2265.

Normalize the entries in the company module definitions in all locales. No entries have been removed. The changes are sorting only.

@xDivisionByZerox xDivisionByZerox added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs c: locale Permutes locale definitions m: company Something is referring to the company module labels May 10, 2024
@xDivisionByZerox xDivisionByZerox added this to the vAnytime milestone May 10, 2024
@xDivisionByZerox xDivisionByZerox requested a review from a team May 10, 2024 16:51
@xDivisionByZerox xDivisionByZerox self-assigned this May 10, 2024
@xDivisionByZerox xDivisionByZerox requested a review from a team as a code owner May 10, 2024 16:51
Copy link

netlify bot commented May 10, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit ca07262
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/6641f26b93f8bc00081b68cb
😎 Deploy Preview https://deploy-preview-2889.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (b27e1a8) to head (ca07262).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2889      +/-   ##
==========================================
- Coverage   99.95%   99.95%   -0.01%     
==========================================
  Files        2977     2977              
  Lines      215466   215466              
  Branches      599      951     +352     
==========================================
- Hits       215379   215373       -6     
- Misses         87       93       +6     
Files Coverage Δ
src/locales/af_ZA/company/suffix.ts 100.00% <100.00%> (ø)
src/locales/cs_CZ/company/suffix.ts 100.00% <100.00%> (ø)
src/locales/da/company/buzz_adjective.ts 100.00% <100.00%> (ø)
src/locales/da/company/buzz_noun.ts 100.00% <100.00%> (ø)
src/locales/da/company/company_name.ts 100.00% <100.00%> (ø)
src/locales/da/company/descriptor.ts 100.00% <100.00%> (ø)
src/locales/da/company/suffix.ts 100.00% <100.00%> (ø)
src/locales/de/company/legal_form.ts 100.00% <100.00%> (ø)
src/locales/de/company/name_pattern.ts 100.00% <100.00%> (ø)
src/locales/de/company/suffix.ts 100.00% <100.00%> (ø)
... and 102 more

... and 2 files with indirect coverage changes

@ST-DDT ST-DDT requested a review from a team May 10, 2024 17:44
@ST-DDT ST-DDT merged commit 5ba44bc into next May 14, 2024
20 checks passed
@ST-DDT ST-DDT deleted the refactor/locale/normalize-company--data branch May 14, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: company Something is referring to the company module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants