Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: backport docs changes to v8 branch #2847

Draft
wants to merge 4 commits into
base: v8
Choose a base branch
from

Conversation

matthewmayer
Copy link
Contributor

Backports to the following changes to v8 branch so that the main fakerjs.dev website can be updated without needing to wait for v9 release.

Copy link

netlify bot commented Apr 23, 2024

Deploy Preview for fakerjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 26d03cc
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/66270c4f3c77200008468aff
😎 Deploy Preview https://deploy-preview-2847.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Shinigami92
Copy link
Member

If we choose this strategy of backporting, we will never --ff-only again

@matthewmayer
Copy link
Contributor Author

If we choose this strategy of backporting, we will never --ff-only again

Is it likely that we will need to merge into v8 in future? Most likely seems to be

  • Minor website updates like this
  • A super-critical bugfix requiring a 8.4.2 release

Is there an alternative to cherry-picking that keeps the history more clear?

@ST-DDT
Copy link
Member

ST-DDT commented May 17, 2024

At this point I dont expect any ff-only merges to v8 anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants