New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency eslint to v9 #2798
base: next
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2798 +/- ##
==========================================
- Coverage 99.95% 99.94% -0.01%
==========================================
Files 2964 2964
Lines 212544 212544
Branches 600 942 +342
==========================================
- Hits 212451 212432 -19
- Misses 93 112 +19 |
c663f98
to
56ad741
Compare
I would like to explore the new eslint v9 and migrate to FlatConfig, so if nobody else has something against that, I would like to "claim" this PR and address some of my time in the upcoming days for this |
92c3bfb
to
db4f46f
Compare
db4f46f
to
de40889
Compare
de40889
to
7ef362e
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
e0ed0a4
to
3605045
Compare
// Skip self linting | ||
'eslint.config.js', | ||
// Skip some files that don't need linting right now | ||
'.github/workflows/commentCodeGeneration.ts', | ||
'.prettierrc.js', | ||
'docs/.vitepress/components/shims.d.ts', | ||
'docs/.vitepress/shared/utils/slugify.ts', | ||
'docs/.vitepress/theme/index.ts', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are getting not applied somehow right now 🤔
// TODO @Shinigami92 2024-04-08: Add eslint-plugin-deprecation later | ||
// https://github.com/gund/eslint-plugin-deprecation/issues/78 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- We should wait until ESLint v9 compatibility gund/eslint-plugin-deprecation#78 is solved
3605045
to
edb5943
Compare
edb5943
to
7dc2145
Compare
7dc2145
to
130504e
Compare
I can confirm that |
Meanwhile in another project I tested out eslint v9 using |
This PR contains the following updates:
8.57.0
->9.0.0
Release Notes
eslint/eslint (eslint)
v9.0.0
Compare Source
Configuration
📅 Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.