Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment a leave request when it contains a postponed worked free day #431

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

benpaquier
Copy link
Contributor

@benpaquier benpaquier commented May 17, 2024

Cette PR rajoute un commentaire à une demande de congé lorsque celle-ci contient un jour férié glissant (aka un jour férié qui tombe un week end).
Cela permet au créateur de la demande ainsi qu'à la personne qui la valide d'être notifié d'un potentiel oubli.

Capture d’écran 2024-05-17 à 17 54 17

⚠️ Cette PR pourra être mergée si la mise en place des "jours fériés glissants" est adoptée.

@benpaquier benpaquier self-assigned this May 17, 2024
@benpaquier benpaquier changed the title Feat: add a comment to a leave request when it contains a postponed w… Comment a leave request when it contains a postponed worked free day May 17, 2024
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.17%. Comparing base (6b542fb) to head (d4aa15c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #431      +/-   ##
==========================================
+ Coverage   91.09%   91.17%   +0.07%     
==========================================
  Files         184      185       +1     
  Lines        2099     2118      +19     
  Branches      151      154       +3     
==========================================
+ Hits         1912     1931      +19     
  Misses        182      182              
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

endDate
)
) {
comment += ` ⚠️ Cette demande de congé contient un ou plusieurs jour(s) férié(s) glissant non pris en compte.`;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je sais pas ou mettre cette string 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant