New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Binder execution button with sphinx library #870
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: kurianbenoy-aot <kurian.benoy@aot-technologies.com>
Signed-off-by: kurianbenoy-aot <kurian.benoy@aot-technologies.com>
@kurianbenoy I spent a few hours comparing this with scikit-learn, and while I don't understand the full picture yet here's something I found: The thing about scikit-learn that confused me a lot was them mentioning a scikit-learn/binder-examples repo which has since been deleted, so I created a PR to fix that comment. scikit-learn/scikit-learn#20480 So the good news seems to be we don't need a separate repo for this either. The other point I'm wondering about is whether the |
@lesteve would you be able to give us a hint? Binder is a bit puzzling us here. |
The scikit-learn approach for sphinx-gallery + Binder is to generate the notebooks inside the Binder docker image through a postBuild step, see https://github.com/scikit-learn/scikit-learn/blob/main/.binder/postBuild. IIRC the standard sphinx-gallery + Binder approach is to have the notebooks in the .github.io website but that was not convenient for scikit-learn (I don't exactly remember the details why I have to admit, edit: maybe to switch between stable and dev doc?, not sure at all ...). |
I also feel trying with @romanlutz thanks for sharing your observation. I am just sharing an observation, ie if you look at the auto_examples generated in scikit-learn website repository you will see only ipython notebooks, while the auto_examples generated in Also just a doubt is CircleCI failing because of the issue #819 ? |
I believe one of the issues with this was sphinx-multiversion which we're no longer using, so we could try this again with the latest state of the repo if someone is up for it. It's been a while, but @kurianbenoy is more than welcome to try again if that's still something they're interested in (?) Let us know! |
Issue: #764
Note:
I am able to successfully run the
make doc
to bring up documentation along with binder button in the website. Yet I am still facing the issue of not having the correct notebook being shown on selectingUpdate: