510 progress bar #559
510 progress bar #559
Conversation
Dref360
force-pushed
the
510-progress-bar
branch
from
099ac14
to
83cf67f
Compare
There was a problem hiding this comment.
Per the discussion on #517 , could you make the tqdm dependency soft?
Signed-off-by: Fred Branchaud <frederic.branchaud-charron@elementai.com>
Signed-off-by: Fred Branchaud <frederic.branchaud-charron@elementai.com>
Signed-off-by: Fred Branchaud <frederic.branchaud-charron@elementai.com>
Dref360
force-pushed
the
510-progress-bar
branch
from
0da3ce0
to
d914f47
Compare
| try: | ||
| from tqdm import tqdm | ||
| except ImportError: | ||
| raise RuntimeError(_TQDM_IMPORT_ERROR_MESSAGE) |
There was a problem hiding this comment.
Rather than raise an exception, since verbose=True is the default, I think it would be kinder to log a warning and behave as if verbose was false.
Tagging @adrinjalali , who first raised a caution around tqdm
There was a problem hiding this comment.
I set verbose default to False so that the user ia not forced to install tqdm.
Didn't that discussion #517 conclude we don't want this dependency at all? Adding @adrinjalali as well. |
|
Yes, the conclusion was to use |
|
Ah! I didn't see that PR, apologies. I'll close this one then. |
|
@Dref360 no worries! If you're up for trying it that way (using logging) please let us know :-) |
Summary
Add a progress bar to GridSearch to inform the user on the progress.
Fixes #510
For
ExponentiatedGradient, we could do the same, but the progress bar would not be complete at the end. Should I add it there as well?