Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Add post-processing algorithm "Discrimination Aware Decision Tree Learning" by Kamiran et al. #1057

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Hadyark
Copy link

@Hadyark Hadyark commented Apr 3, 2022

This PR will solve #1024 and implements the Relabeling from the paper Discrimination Aware Decision Tree Learning by Kamiran et al.

  • postprocessing technique code in fairlearn.postprocessing
  • unit tests in test.unit.postprocessing
  • descriptive API reference (directly in the docstring)
  • example notebook
  • a short user guide in docs.user_guide.mitigation.rst

Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Hadyark .

A few notes:

  • Please make sure your lines are not too long, including in the documentation, lines should be <88 chars long.
  • The main entry point should be a somewhat scikit-learn compatible estimator, added to the corresponding __init__.py file and exposed publicly.
  • We follow numpydoc standard for docstrings, please have a look at the existing classes/methods and adapt the docstrings accordingly.
  • Your .ipynb notebook file should be converted into a .py file with the same format as the other examples in examples folder.

I have approved the CI and merging with the latest main should render your documentation for us here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants