New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH Add "Reweighing" #1017
base: main
Are you sure you want to change the base?
ENH Add "Reweighing" #1017
Conversation
Hey @romanlutz , in #784 you mention you'd ideally have a short section in mitigation.rst about this. Does that still hold now? I remember hearing that mitigation.rst will be changed a lot so don't know if it is wiser to add this as an issue for later? |
Multi-dimension support for sensitive features should be added in the first version simply because we already have functionality to map multiple into a single dimension. If you need a reference please lmk and I'll send it (currently typing on phone). The user guide would be nice to have in the first version, too. I think that's one of the requirements we have these days for adding new functionality. The mitigation.rst is typically undergoing changes, and I think that will always be like this. Just add your changes where you think it's best and we'll reevaluate then. I'm sure it's easy to adjust as this doesn't build onto an existing section of content. Does that make sense to you? |
Done!
Please have a look :) |
06a54fd
to
0682df9
Compare
Add Reweighing preprocessing technique. #784
Design choices:
y
and 1dsensitive_features
Progress
During this implementation, I thought of some improvements in future versions. I don't want to make an issue but here are my thoughts: