Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not honor center view controller supportedInterfaceOrientations property #54

Open
robertcrabtree opened this issue Feb 6, 2019 · 0 comments

Comments

@robertcrabtree
Copy link

Issue:

I found an issue where the panel controller does not check the supportedInterfaceOrientations property of the centered view controller when rotating. Check out the documentation for supportedInterfaceOrientations here: https://developer.apple.com/documentation/uikit/uiviewcontroller/1621435-supportedinterfaceorientations

Let's say you set the panel controller's center view controller to be a tab bar controller. I don't want the tab bar controller to rotate. I do that by setting supportedInterfaceOrientations = .portrait. Now let's say you present a modal view controller from the tab bar controller. You should be able to rotate the modal view controller just fine. But the tab bar controller should not be anything other that portrait when you close the modal view controller, even if the phone orientation is landscape.

I created a sample project to demonstrate the problem. I'm using the default config in the sample project here: https://github.com/robertcrabtree/FAPanelsRotation. Can you please take a look?

To reproduce:

  1. Download sample project
  2. Run pod install
  3. Launch iPhone simulator in portrait mode
  4. Press the modal button
  5. Rotate the presented modal view controller to landscape
  6. Dismiss the modal view controller
  7. Notice the tab bar is also in landscape

Thanks! Let me know if you need me to clarify anything else.

@fahidattique55 fahidattique55 added this to To Do in Aiana Apr 11, 2019
@fahidattique55 fahidattique55 removed this from To Do in Aiana Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant