Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to close side panel by swiping sidepanel itself too. #36

Open
Shamsiddin opened this issue Jul 29, 2018 · 2 comments
Open

Ability to close side panel by swiping sidepanel itself too. #36

Shamsiddin opened this issue Jul 29, 2018 · 2 comments

Comments

@Shamsiddin
Copy link

Shamsiddin commented Jul 29, 2018

In current condition of the lib it is impossible to close side panel by swiping it.
In order to close it you should tap, or swipe the grayed area only (look at the pic to see swipeable and not swipeable areas).
From UX point of view it isn't convenient to swipe only this grayed area to close it.
I HIGHLY recommend You to integrate this closing ability of side panel by swiping the entire screen (not only the grayed area)!

Or it would be good if user himself can decide/set the swipeable area type.
Possible values are :

enum SwipeableArea {
    case entireScreen
    case sidePanel
    case grayedArea // outside of side menu
}

simulator screen shot - iphone 6 - 2018-07-29 at 09

@andrew-locklair
Copy link

@fahidattique55 Is this something that you would accept PRs on? This feature would help us and I'm wondering if I could attempt to implement.

@fahidattique55
Copy link
Owner

@xparabolax

PRs are always appreciated. Please implement and help the world 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants