Fix lint / tests #730
Fix lint / tests #730
Conversation
suchenzang
requested review from
ngoyal2707,
punitkoura,
moyapchen,
klshuster,
davides,
igormolybogFB,
Xirider,
andrewPoulton,
bashnick,
tangbinh,
urielsinger,
zycalice,
ArmenAg,
lilisierrayu and
adampolyak
as code owners
| @@ -495,6 +495,8 @@ def validate_and_save( | |||
| async_callback_fn=functools.partial( | |||
| post_checkpoint_callback, cfg, num_updates, should_stop | |||
| ) | |||
| if cfg.checkpoint.cloud_upload_path | |||
| else None, | |||
There was a problem hiding this comment.
Actually as a quick - what's up with this line?
There was a problem hiding this comment.
Don't think it should've been removed in #724 , but needing to isolate the test failures coming from setuptools version now.
|
Hi @suchenzang! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
No description provided.