Generation should stop after two new lines if that is the stop criteria #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vidyaranya
requested review from
suchenzang,
ngoyal2707,
punitkoura,
moyapchen,
klshuster,
davides,
igormolybogFB,
Xirider,
andrewPoulton,
bashnick,
tangbinh,
urielsinger,
zycalice,
ArmenAg,
lilisierrayu and
adampolyak
as code owners
|
Rebase on main, and tests will probably pass! |
Summary: This addresses Issue 642. When the stop token is \n\n the generation should stop after generation two new lines.
Vidyaranya
force-pushed
the
recurring_token_fix
branch
from
a13f5a3
to
d704750
Compare
They still seem to fail! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses Issue 642. When the stop token is \n\n the generation should stop after generation two new lines.
Check the previous token that is generated and if it is repeated, and if the stop token contains this as the criteria, stop generating further tokens