Adding flash attention for sequence parallel #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dianaml0
requested review from
suchenzang,
stephenroller,
ngoyal2707,
punitkoura,
moyapchen,
klshuster,
ruanslv,
davides,
igormolybogFB and
Xirider
as code owners
dianaml0
force-pushed
the
flash_seqpar_v2
branch
from
fe89b3b
to
16c91d1
Compare
|
CircleCI failure not related to this PR |
|
Can we rebase for checks? Should we be concerned about the last bits of numerical differences? |
dianaml0
force-pushed
the
flash_seqpar_v2
branch
from
2f05657
to
cb3a4ee
Compare
|
@stephenroller just rebased the PR, should be up to date now. The rtol and atol used are the same ones we use for testing in xFormers for all flash attention bwds. I do a small training run to validate, would that be useful? |
dianaml0
force-pushed
the
flash_seqpar_v2
branch
from
cb3a4ee
to
135972e
Compare
|
Looks like everything is passing now after rebasing |
dianaml0
force-pushed
the
flash_seqpar_v2
branch
from
390b808
to
9401934
Compare
dianaml0
force-pushed
the
flash_seqpar_v2
branch
from
9401934
to
d0aa8b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch Description
Creating this PR off of #511, so it can be reviewed by @stephenroller
The last commit (3d709db) removes some changes from the sequence parallel code which enabled testing with world size of 1. CI is not currently running the test anyway because CI needs to be updated for the test to run.
The forward and backward tests are passing right now. However in some cases, about .2% of the elements fail
Testing steps
Unit Test
gpu_tests/test_sequence_parallel_transformer_layer.py