Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--[WIP][BE/Refactor/Bugfix] Remove deprecated distutils from setup and ab_test #2202

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

--[WIP][BE/Refactor/Bugfix] Remove deprecated distutils from setup and ab_test #2202

wants to merge 3 commits into from
+40 −10

Conversation

jturner65
Copy link
Contributor

@jturner65 jturner65 commented Sep 13, 2023 •
edited

Motivation and Context

Distutils is deprecated and will be removed in python 3.12, which is slated for release Oct 2 2023. This PR removes references to Distutils in HabitatSim python code. It does require the 'packaging' library, so this also needs to be added to requirements.txt. (@Skylion007 is there a better option than this to provide version classes?)

NOTE : Our versions of bullet, assimp and pybind11 all also have distutils references, so we may need to update these libraries before we can claim python 3.12 support. (magnum also does, but I'm sure mosra will address when appropriate).

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Sep 13, 2023
@jturner65 jturner65 force-pushed the RemoveDistutilsFromSetup branch 5 times, most recently from 94b0634 to 7399bf4 Compare September 27, 2023 19:12
@jturner65 jturner65 force-pushed the RemoveDistutilsFromSetup branch 3 times, most recently from 7c7bdb4 to 246500f Compare October 12, 2023 13:21
@jturner65 jturner65 force-pushed the RemoveDistutilsFromSetup branch 2 times, most recently from e7c3f98 to 153c984 Compare October 26, 2023 15:28
@jturner65 jturner65 force-pushed the RemoveDistutilsFromSetup branch 2 times, most recently from 36750ac to a73637b Compare November 29, 2023 14:25
@jturner65 jturner65 force-pushed the RemoveDistutilsFromSetup branch 4 times, most recently from 1d3155f to 3139d0c Compare December 12, 2023 18:13
Skylion007
Skylion007 approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@Skylion007 Skylion007 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably also bump the supported versions for our conda builds.

@Skylion007
Copy link
Contributor

Latest version of pybind11 supports python 3.12. Also latest versions of torch will too now.

@jturner65 jturner65 force-pushed the RemoveDistutilsFromSetup branch 2 times, most recently from a21bc23 to f4075ad Compare January 4, 2024 13:52
@jturner65 jturner65 force-pushed the RemoveDistutilsFromSetup branch 2 times, most recently from f6767f7 to 46c8648 Compare January 9, 2024 21:16
@jturner65 jturner65 force-pushed the RemoveDistutilsFromSetup branch 2 times, most recently from e837ec8 to 525f351 Compare February 15, 2024 14:08
@jturner65 jturner65 force-pushed the RemoveDistutilsFromSetup branch 2 times, most recently from 31457d5 to 5ef06da Compare February 26, 2024 17:27
@jturner65 jturner65 force-pushed the RemoveDistutilsFromSetup branch 6 times, most recently from 5a70ec9 to 11bada4 Compare March 5, 2024 19:25
@jturner65 jturner65 force-pushed the RemoveDistutilsFromSetup branch 4 times, most recently from ec42b09 to d4063df Compare March 20, 2024 16:15
@jturner65 jturner65 force-pushed the RemoveDistutilsFromSetup branch 2 times, most recently from e4b3399 to 96c64ce Compare April 8, 2024 14:05
@jturner65 jturner65 force-pushed the RemoveDistutilsFromSetup branch 2 times, most recently from 68e9268 to 690548d Compare April 22, 2024 13:34
@jturner65 jturner65 force-pushed the RemoveDistutilsFromSetup branch 4 times, most recently from 2c2003c to 6e86d99 Compare May 2, 2024 13:19
@jturner65 jturner65 force-pushed the RemoveDistutilsFromSetup branch 3 times, most recently from e372b20 to fc1fd0f Compare May 9, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@aclegg3 aclegg3 Awaiting requested review from aclegg3

@0mdc 0mdc Awaiting requested review from 0mdc

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jturner65 @Skylion007 @facebook-github-bot